This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][C] Fix PR59905, remove code replacing calls with abort
- From: Richard Biener <rguenther at suse dot de>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 30 Jan 2014 15:16:49 +0100 (CET)
- Subject: Re: [PATCH][C] Fix PR59905, remove code replacing calls with abort
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1401291223240 dot 29326 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1401291456310 dot 29326 at zhemvz dot fhfr dot qr> <Pine dot LNX dot 4 dot 64 dot 1401291704500 dot 18783 at digraph dot polyomino dot org dot uk>
On Wed, 29 Jan 2014, Joseph S. Myers wrote:
> On Wed, 29 Jan 2014, Richard Biener wrote:
>
> > testing reveals diagnostic regressions
> >
> > FAIL: gcc.dg/call-diag-2.c abort (test for warnings, line 12)
> > FAIL: gcc.dg/call-diag-2.c abort (test for warnings, line 15)
> > FAIL: gcc.dg/invalid-call-1.c (test for warnings, line 16)
> >
> > which may be hard to preserve (didn't investigate thoroughly yet),
> > one is probably emitted via the call to require_complete_type
> > I remove.
> >
> > Is it ok to adjust the testcases expectation for what is produced now?
>
> These appear to be about the "will abort" diagnostics - removing those
> dg-message tests, while keeping the dg-warning tests, is fine.
Ah, indeed. I've adjusted the testcases and committed the patch.
Thanks,
Richard.