This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR59890, improve var-tracking compile-time
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 21 Jan 2014 11:11:34 -0200
- Subject: Re: [PATCH] Fix PR59890, improve var-tracking compile-time
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1401201948050 dot 4623 at zhemvz dot fhfr dot qr> <or1u02tn97 dot fsf at livre dot home> <20140120203150 dot GD892 at tucnak dot redhat dot com>
On Jan 20, 2014, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Jan 20, 2014 at 06:24:36PM -0200, Alexandre Oliva wrote:
>> But I think this one is wrong.
>> if (var->onepart == ONEPART_VALUE)
>> {
>> if (local_get_addr_cache == NULL)
>> return;
> But when local_get_addr_cache is non-NULL, no matter if we find a slot there
> or don't, we still fall thru into the 3 loops etc.
Uhh, yes indeed... Evidently I imagined a return at the end of this
if :-/
The patch is good then; but what is my review worth after barfing like
that? :-D
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Toolchain Engineer