This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ipa references removal

From: Jeff Law <law at redhat dot com>
To: Ilya Enkovich <enkovich dot gnu at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 16 Jan 2014 09:36:32 -0700
Subject: Re: [PATCH] Fix ipa references removal
Authentication-results: sourceware.org; auth=none
References: <CAMbmDYZmRybHDVBvS3RMei74U1+Pk3Wg51on+w-afLNRCs2J=Q at mail dot gmail dot com>

On 01/16/14 07:24, Ilya Enkovich wrote:

Hi,

I found ipa_remove_stmt_references incorrectly iterates over
references after reference removal. When reference is removed, the
last one takes it's place and is not checked at all. It means we do
not remove all required references in some cases.

Here is a patch to fix it. Bootstrapped and tested on linux-x86_64. OK
for trunk?

Thanks,
Ilya
--
2014-01-16  Ilya Enkovich  <ilya.enkovich@intel.com>

         * ipa-ref.c (ipa_remove_stmt_references): Fix references
         traversal when removing references.

OK for the trunk.

Do you have a testcase that can be added to the regression suite?

jeff

Follow-Ups:
- Re: [PATCH] Fix ipa references removal
  - From: Ilya Enkovich

References:
- [PATCH] Fix ipa references removal
  - From: Ilya Enkovich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]