This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: experimental testsuite patch
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 15 Jan 2014 17:17:25 +0000
- Subject: Re: experimental testsuite patch
- Authentication-results: sourceware.org; auth=none
- References: <52D6BDC7 dot 1000803 at gmail dot com>
On 15 January 2014 16:56, François Dumont wrote:
> Hi
>
> Here is a patch to partially fix 2 string_view tests. It looks like we
> can't use 2 dg-options into the same source, one override the over, the
> dg-options directives have been merged into 1. I also update a script to
> make the experimental folder part of the folders to look for tests. I don't
> know if it was intentionally omitted because of the experimental aspect of
> what is tested, if so just tell me I won't apply this part.
I think it's OK.
> Remaining failures in string_view tests in debug mode are all coming
> from this kind of code:
>
> constexpr const _CharT&
> operator[](size_type __pos) const
> {
> _GLIBCXX_DEBUG_ASSERT(__pos <= this->_M_len);
> return *(this->_M_str + __pos);
> }
>
> In debug mode the _GLIBCXX_DEBUG_ASSERT is activated and the operator
> cannot be a constexpr anymore. Maybe Ed can tell what should be done,
> remove the assertion or remove the constexpr (maybe only in debug mode ?) ?
I think we decided we want functions to be constexpr in debug mode if
they are constexpr in normal mode.
I think std::array has solved the same problem without losing the
constexpr qualifier.
> 2014-01-15 François Dumont <fdumont@gcc.gnu.org>
>
> * scripts/create_testsuite_files: Add testsuite/experimental in
> the list of folders to introspect for tests.
s/introspect/inspect/
The patch is OK with that change, thanks.,