This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow building if libsanitizer on RHEL5 (i.e. with 2.6.18-ish kernel headers, take 2)
- From: Dodji Seketeli <dodji at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>, Dodji Seketeli <dseketel at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 09 Jan 2014 09:55:15 +0100
- Subject: Re: [PATCH] Allow building if libsanitizer on RHEL5 (i.e. with 2.6.18-ish kernel headers, take 2)
- Authentication-results: sourceware.org; auth=none
- References: <20131206124342 dot GL892 at tucnak dot redhat dot com> <20131210113410 dot GP892 at tucnak dot redhat dot com>
Jakub Jelinek <jakub@redhat.com> writes:
> Hi!
>
> Here is an updated version which doesn't warn about #include_next.
> Ok for trunk?
>
> 2013-12-10 Jakub Jelinek <jakub@redhat.com>
>
> * sanitizer_common/Makefile.am (AM_CPPFLAGS): Add
> -isystem $(top_srcdir)/include/system.
> * sanitizer_common/Makefile.in: Regenerated.
> * include/system/linux/aio_abi.h: New header.
> * include/system/linux/mroute.h: New header.
> * include/system/linux/mroute6.h: New header.
> * include/system/linux/perf_event.h: New header.
> * include/system/linux/types.h: New header.
This looks good to me. A better approach would have been what you said
in another thread:
| much better would be just say a testcase that would include the
| sanitizer + kernel headers, guarded by recent enough LINUX_VERSION_CODE
| or configure or similar, so it wouldn't prevent library build on older
| kernel headers, the kernel ABI better be stable (only new things added,
| not size of structures/magic constants etc. changed from time to time).
But because of:
| But Kostya is apparently not willing to do that, so this patch
| provides a workaround in non-compiler-rt maintained files.
Let's get this in then :-)
Cheers.
--
Dodji