Re: Drop -m32 from pr59099.c

[Uros Bizjak <ubizjak at gmail dot com>]

Hello!

>> gcc.target/i386/pr59099.c fails on x86_64-redhat-linux-gnu with
>> --disable-multilib because linking -m32 code is not supported.  The
>> test case passes in 64-bit mode as well.  The other -m32 tests do
>> not use dg-do run, so they do not exhibit this problem.
>>
>> Okay for trunk?
>
> No, this IMHO really should be:
> /* { dg-do run { target { ia32 && fpic } } } */
> /* { dg-options "-O2 -fPIC" } */
>
> All tests in gcc.target/i386 having -m32 (or -m64) in dg-options
> are buggy and should be fixed, either by adding { target ia32 }
> to their dg-do compile or whatever other dg-do they have, or
> adding
> /* { dg-require-effective-target ia32 } */
> line and dropping the -m32 from dg-options.

I have committed following testsuite patch that removes -m32 from
options. Also, the patch includes check for fpic effective target when
-fpic is used.

2014-01-08  Uros Bizjak  <ubizjak@gmail.com>

    * gcc.target/i386/asm-1.c: Remove dg-options.
    * gcc.target/i386/incoming-5.c (dg-options): Remove -m32.
    * gcc.target/i386/pr55433.c (dg-options): Ditto.
    * gcc.target/i386/pr57848.c (dg-options): Ditto.
    * gcc.target/i386/pr59099.c (dg-options): Ditto.
    Require fpic effective target.
    * gcc.target/i386/pr56246.c (dg-do): Compile for fpic target only.

Tested on x86_64-pc-linux-gnu {,-m32}, will be committed to mainline
in a moment.

Uros.

Attachment: t.diff.txt
Description: Text document