This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] libgcov.c re-factoring
- From: Teresa Johnson <tejohnson at google dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: Xinliang David Li <davidxl at google dot com>, Rong Xu <xur at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, amacleod at redhat dot com, Jeff Law <law at redhat dot com>, dmalcolm at redhat dot com
- Date: Wed, 8 Jan 2014 08:38:03 -0800
- Subject: Re: [Patch] libgcov.c re-factoring
- Authentication-results: sourceware.org; auth=none
- References: <CAAe5K+XjrGDi9sX4TFYpuefy8_v=JUmahYENpG43oB-tGoVBeQ at mail dot gmail dot com> <20131222182733 dot GB13888 at kam dot mff dot cuni dot cz> <CAAe5K+UVRxducrP=KXRmwuUSbo5yy09-mM-E8uKa1ZFkObrgrQ at mail dot gmail dot com> <20140105200836 dot GA30733 at kam dot mff dot cuni dot cz> <CAAe5K+UFjPL9JYhyo1_7hP8ZTRmqpoyzMt9gUZ=q1TLkzQ26fA at mail dot gmail dot com> <CAAe5K+UjPEKPc51TN72QV217HhHyStwaVOiKLkpW+FXZBh08=g at mail dot gmail dot com> <20140108143442 dot GA2935 at kam dot mff dot cuni dot cz>
On Wed, Jan 8, 2014 at 6:34 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>>
>> Actually, I tried changing these two, but gcc_checking_assert is
>> undefined in libgcov.a. Ok to commit without this change?
>
> OK.
> incrementally can you please define gcov_nonruntime_assert that will wind into
> gcc_assert for code within gcc/coverage tools and into nothing for libgcov
> runtime and we can change those offenders to that.
Ok, committed as r206435. Will send the assert patch in a follow-up
later this week.
Teresa
>
> Honza
>>
>> Teresa
>>
>> >
>> > Thanks,
>> > Teresa
>> >
>> >>
>> >> Thanks,
>> >> Honza
>> >
>> >
>> >
>> > --
>> > Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>>
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413