This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] _Cilk_for for C and C++
- From: Jason Merrill <jason at redhat dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>, "'Jeff Law'" <law at redhat dot com>, "'Aldy Hernandez'" <aldyh at redhat dot com>
- Cc: "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>, "'rth at redhat dot com'" <rth at redhat dot com>, "'Jakub Jelinek'" <jakub at redhat dot com>
- Date: Tue, 07 Jan 2014 15:40:55 -0500
- Subject: Re: [PATCH] _Cilk_for for C and C++
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A49F0C1 at FMSMSX101 dot amr dot corp dot intel dot com> <52869727 dot 4060307 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4A8DA6 at FMSMSX101 dot amr dot corp dot intel dot com> <528F8A42 dot 1040704 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AC599 at FMSMSX101 dot amr dot corp dot intel dot com> <52962687 dot 2020107 at redhat dot com> <52964B50 dot 6090006 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AD05D at FMSMSX101 dot amr dot corp dot intel dot com> <529693B0 dot 4050005 at redhat dot com> <529D7A76 dot 1080001 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4AE391 at FMSMSX101 dot amr dot corp dot intel dot com> <BF230D13CA30DD48930C31D4099330003A4B2148 at FMSMSX101 dot amr dot corp dot intel dot com> <52AF6EE8 dot 2080807 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A4B2BA2 at FMSMSX101 dot amr dot corp dot intel dot com>
On 12/17/2013 07:21 PM, Iyer, Balaji V wrote:
The reason why I store it in OMP_FOR_CLAUSE is because OMP clauses cannot occur in _Cilk_for. So adding a new clause seem to be an overkill IMHO. I need a place to store the grain value and so I chose this spot.
But code expects OMP_FOR_CLAUSES to have a certain form, and you are
violating that so that now code needs to check whether we're dealing
with a for loop in order to know to parse OMP_FOR_CLAUSES. Doing it
your way requires lots of little special cases. Please represent it as
a clause.
Jason