This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR59471


On Tue, 7 Jan 2014, Jakub Jelinek wrote:

> On Tue, Jan 07, 2014 at 03:54:56PM +0100, Richard Biener wrote:
> > 
> > This fixes PR59471 by properly gimplifying
> > 
> >   VIEW_CONVERT_EXPR<uint8x8_t>(BIT_FIELD_REF <VIEW_CONVERT_EXPR<vector(2) 
> > long unsigned int>(x), 64, 0>)
> > 
> > to use separate stmts for the VIEW_CONVERT_EXPRs.
> > 
> > Bootstrap and regtest running on x86_64-unknown-linux-gnu.
> 
> What about if something post gimplification creates VCE(BFR(VCE())) or
> similar and tries to force_gimple_operand_gsi or similar, then without
> making the above invalid in the predicates we'd still not try to gimplify it
> at all (because it would pass the predicate), and then hit the verification
> ICE.

I don't think it passes any predicate, certainly not is_gimple_val,
so we enter gimplification anyway.  Or am I missing something?

Thanks,
Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]