This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pch bug fix (take 2, PR pch/59436)


On 01/01/14 16:08, Jakub Jelinek wrote:
On Wed, Jan 01, 2014 at 07:53:48PM +0100, Jakub Jelinek wrote:
Without any gengtype.c changes, I wonder if just following change wouldn't
do it, gengtype considers only char and unsigned char pointers as strings
with the special strlen handling, all other scalar types are treated
differently it seems, and signed char aliases everything too.

Or s/signed char/void/ in the patch is perhaps even better.

I've bootstrapped/regtested this on x86_64-linux and i686-linux,
and hopefully verified the problem from the PR is gone, by running over
610 successful PCH write + PCH read cycles as described in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59436#c14 , no failures
with the patch, while on a tree from yesterday without the patch I could
reproduce it 17 times, on average every 22 iterations (from 2 to 81).

Ok for trunk (and after a while for 4.8)?

2014-01-01  Mike Stump  <mikestump@comcast.net>
	    Jakub Jelinek  <jakub@redhat.com>

	PR pch/59436
	* tree-core.h (struct tree_optimization_option): Change optabs
	type from unsigned char * to void *.
	* optabs.c (init_tree_optimization_optabs): Adjust
	TREE_OPTIMIZATION_OPTABS initialization.
OK for the trunk.  Release managers have final say on 4.8.

I hope this was the root cause of the occasional PCH failure I was seeing as well.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]