This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] libgcov.c re-factoring


On 12/22/2013 01:27 PM, Jan Hubicka wrote:

I believe when the code was created by moving it from elsehwre, the copyright should say
original date of gcov-io.h.
+
+#include "tconfig.h"
+#include "tsystem.h"
+#include "coretypes.h"
+#include "tm.h"
+#include "libgcc_tm.h"
....
I would really like someone working on header restructuring to comment on
those.
I am not 100% sure what our best practices currently are in respect of
including headers within headers and specially after good amount of
defines like gcov-io.h gets included.


Just back..

For the moment the goal with headers is to completely flatten them.. ie, we do not want to include header files from header files. Once there is a sensible restructuring of things in place, we are likely to reintroduce them in a controlled and sensible manner.

So at the moment, I'd like to not include any additional .h files from within .h files...

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]