This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, Gabriel Dos Reis <gdr at integrable-solutions dot net>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 20 Dec 2013 13:16:45 +0100
- Subject: Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY
- Authentication-results: sourceware.org; auth=none
- References: <1365105210-16552-1-git-send-email-rep dot dot dot nop at gmail dot com> <1365105210-16552-3-git-send-email-rep dot dot dot nop at gmail dot com> <CAAiZkiBiUc8=dx54kWKVjDE6sCjzyTgKUZiC65=NdVi_Mg=5rg at mail dot gmail dot com> <ydd1uapic5b dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CAAiZkiAqeHNOhkZ1FgWg1eSz4mF+9fvF1k9sLaO3hxab-X2WRg at mail dot gmail dot com> <yddwqshgx0s dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <CAAiZkiDp07LpKYHZTuQ1pW0niLpZm+3qWN4J0m0=KUNKuTGa7g at mail dot gmail dot com> <CAC1BbcQQJ-W078_+ag4H2voeSCnCut9LXyG6_kBd1+nvBQX30g at mail dot gmail dot com> <CAC1BbcRsGRPJxtsi=d+T6g_8pEH0rWW0JdAPGt78U+TAV05Guw at mail dot gmail dot com> <5166AA2C dot 5090001 at oracle dot com> <CAC1BbcTPDp9eQ=HERDo5Z7W=2eYpkBwZfa=q7qm=9-5dEEtf_g at mail dot gmail dot com> <CAH6eHdS20L49HCAhTkuROBvkCuf_B8SKXQA55Cs=FKkmJpEosQ at mail dot gmail dot com> <CAC1BbcSvmL_DXZmxPURWOCWUiaSx3Vho5v2NCc9U6opOMY-XzA at mail dot gmail dot com> <CAH6eHdRE4L9-6OT95B7W905qCSCDXBQagYLLK5Db=BwxMFo_cQ at mail dot gmail dot com>
On 13 November 2013 18:56, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> On 13 November 2013 09:22, Bernhard Reutner-Fischer wrote:
>> On 11 November 2013 12:30, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>>> How does __UCLIBC_SUSV4_LEGACY__ get defined? We'd have a problem if
>>> users defined that at configure time but not later when using the
>>> library.
>> That would be defined by uClibc's configury, but the latest
>> "commit-6f2faa2" i attached does not mention this anymore, but does
>> the check in a libc-agnostic manner?
>
> Yes, but I was concerned about whether the value of that macro can
> change between configuring libstdc++ and users compiling code using
> libstdc++. If it could change (e.g. by users compiling with
> -D_POSIX_C_SOURCE=200112L or some other feature test macro) then the
> value of _GLIBCXX_USE_TMPNAM (which doesn't change) would be
> unreliable and we could end up with a "using ::tmpnam" in the library
> that causes errors when users compile.
>
> If it's set when configuring uClibc then it is a constant for a given
> libstdc++ installation, so the value of _GLIBCXX_USE_TMPNAM is
> reliable. In that case your change is OK to commit (with or without
> the "XYZ" change) - thanks.
It is a constant, yes. I will push this after another round of regtests
against current trunk as time permits.
thanks,