This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

From: "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>
To: Uros Bizjak <ubizjak at gmail dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Thu, 19 Dec 2013 10:01:19 +0000
Subject: RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
Authentication-results: sourceware.org; auth=none
References: <EB4625145972F94C9680D8CADD6516155E73BF13 at SATLEXDAG02 dot amd dot com> <CAFULd4Y6XyUTZk0j2opkMQPWMp+U-pv0rN0NbJusffudEv00Fw at mail dot gmail dot com> <EB4625145972F94C9680D8CADD6516155E741F49 at SATLEXDAG02 dot amd dot com> <CAFULd4YcuD8-HaszKNPM2xvtjgu2BX0K4WGGRUE868fTv5OjzQ at mail dot gmail dot com> <EB4625145972F94C9680D8CADD6516155E764DAD at satlexdag04 dot amd dot com> <CAFULd4YeiCa-ma1CVB=qk164qW+2WkDLdkJwJVe4i==S1_cT8Q at mail dot gmail dot com>

> Please provide updated ChangeLog.

--- gcc/ChangeLog	(revision 206106)
+++ gcc/ChangeLog	(working copy)
@@ -1,3 +1,14 @@
+2013-12-19  Ganesh Gopalasubramanian  <Ganesh.Gopalasubramanian@amd.com>
+
+	* config/i386/i386.c: Include cfgloop.h. 
+	(ix86_loop_memcount): New function.
+	(ix86_loop_unroll_adjust): New function.
+	(TARGET_LOOP_UNROLL_ADJUST): Define.
+	* config/i386/i386.h
+	(TARGET_ADJUST_UNROLL): Define.
+	* config/i386/x86-tune.def
+	(X86_TUNE_ADJUST_UNROLL): Define.
+

> The function comment is missing. Maybe you should also describe magic number 32 here?
Added the function comment.

> Otherwise, the patch looks OK.
Thanks.  Bootstrapping passes. Is it OK for upstream?

> BTW: Please avoid top-posting, see e.g. [1] for reasons...
Sorry for the lapse. Will comply.

Regards
Ganesh

Attachment: unroll-adjust.patch
Description: unroll-adjust.patch

Follow-Ups:
- Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
  - From: Uros Bizjak

References:
- RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
  - From: Gopalasubramanian, Ganesh
- Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
  - From: Uros Bizjak
- RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
  - From: Gopalasubramanian, Ganesh
- Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]