This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386 testsuite]: Fix -mabi=ms related failures for -mtune=corei7
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: Dominique Dhumieres <dominiq at lps dot ens dot fr>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 18 Dec 2013 11:56:52 +0100
- Subject: Re: [PATCH, i386 testsuite]: Fix -mabi=ms related failures for -mtune=corei7
- Authentication-results: sourceware.org; auth=none
- References: <20131215115857 dot 8F1BF104 at mailhost dot lps dot ens dot fr> <CAFULd4b1jLvmBLTPWQC=Lui1Wr=m1CPrq6o-8-q=qU5fGNUDew at mail dot gmail dot com> <20131215121453 dot 05107104 at mailhost dot lps dot ens dot fr> <CAFULd4YGnG18GJBqa=qQaccNRxFCd-5NmpUeMOSS6LuzcHgcFw at mail dot gmail dot com> <ydd4n66o2u8 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
On Wed, Dec 18, 2013 at 11:44 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>> On Sun, Dec 15, 2013 at 1:14 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>>>> OTOH, I can't test darwin properly, please provide the patch and I'll
>>>> commit it for you.
>>>
>>> Basically the patch I have in my tree since the PR replace 'linux' with
>>> *' (see below).
>>> Since I can only test darwin, there is no guarantee that the tests pass
>>> on non-linux,
>>> non-darwin platforms. So if you apply the patch below as such, it will be
>>> necessary to
>>> watch out for fall-out.
>>
>> Let's ask Rainer for help with x86 solaris.
>
> I've just applied Dominique's patch to r206061 and ran the four changed
> tests on i386-pc-solaris2.10: all of them passed, so from my POV the
> change is fine.
So, the proposed patch (with proper ChangeLog) is OK and preapproved.
Thanks,
Uros.