This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GOMP_target: alignment (was: [gomp4] #pragma omp target* fixes)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Henderson <rth at redhat dot com>, "Michael V. Zolotukhin" <michael dot v dot zolotukhin at gmail dot com>, jnorris at codesourcery dot com
- Date: Mon, 16 Dec 2013 17:58:26 +0100
- Subject: Re: GOMP_target: alignment (was: [gomp4] #pragma omp target* fixes)
- Authentication-results: sourceware.org; auth=none
- References: <20130905161105 dot GL23437 at tucnak dot redhat dot com> <87zjo6s8e9 dot fsf at kepler dot schwinge dot homeip dot net> <87fvptqm41 dot fsf at kepler dot schwinge dot homeip dot net> <20131216153818 dot GM892 at tucnak dot redhat dot com> <87iouoiwiv dot fsf at schwinge dot name>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Dec 16, 2013 at 05:35:36PM +0100, Thomas Schwinge wrote:
> Sure, that's fine by me, and thanks for the explanation.
>
> > Plus, the change, being an ABI change, would need to be done on the
> > trunk rather than just on gomp-4_0-branch.
>
> It's not an ABI change, as I had limited the change to the GOACC_parallel
> function, which does not yet exist in trunk.
Ah, ok then, I've missed that. I'd indeed prefer if you just used one
array, it can be say just uchar array of twice the width, with even chars
for alignment and odd for kinds (or vice versa), compared to two arrays
it is tiny bit cheaper at the caller side IMHO.
Jakub