This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Cleanup patches, mostly in the realm of OpenMP


Hi!

On Mon, 16 Dec 2013 09:58:07 +0100, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Dec 13, 2013 at 11:12:03AM +0100, Thomas Schwinge wrote:
> > OK to apply the following cleanup patches to trunk, assuming that testing
> > (still running) is fine?

Thanks for the review!


> >     Reflect reality in comment.
> >     
> >     	gcc/
> >     	* omp-low.c (check_combined_parallel): Reflect reality in
> >     	comment; from the initial r126226.
> 
> Ok (without "; from the initial r126226").

Noted; GCC does not keep such cross-links in the revision history.
(Admittedly not much point, for these cleanup ones.)

> >     Fix typo in dg-warning comment.
> >     
> >     	gcc/testsuite/
> >     	* gcc.dg/dfp/wtr-conversion-1.c (testfunc1): Fix typo, from the
> >     	initial r109604.
> 
> Ok, but again, ", from the initial r109604" unneeded here.
> 
> >     Remove leftover comment.
> >     
> >     	gcc/
> >     	* omp-low.c: Remove leftover comment from function removed in
> >     	r112935.
> 
> Ok.
> 
> >     	gcc/
> >     	* tree-pass.h (make_pass_expand_omp_ssa): Remove leftover
> >     	declaration of function removed in r135786.
> 
> Ok, but just Remove.
> 
> >     Remove leftover variable definition.
> >     
> >     	gcc/
> >     	* omp-low.c (tmp_ompfn_id_num): Remove leftover definition of
> 
> Ok, but just Remove.
> 
> >     	variable that is unused as of r160016.


GrÃÃe,
 Thomas

Attachment: pgpIkkCVhshfA.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]