This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RFA: revert libstdc++ r205810: simulator workload increase caused regression
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Cc: Renlin dot Li at arm dot com, Yufeng dot Zhang at arm dot com
- Date: Sun, 15 Dec 2013 07:57:23 +0100
- Subject: RFA: revert libstdc++ r205810: simulator workload increase caused regression
- Authentication-results: sourceware.org; auth=none
>From the revision range 205803:205810 (excluding:including) an
on, my autotester for cris-elf reports a regression:
Running /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ...
WARNING: program timed out.
FAIL: 20_util/hash/chi2_quality.cc execution test
This appears to have come from revision r205810. I can't find
the discussion or approval leading to that commit. It seems
likely to have been a mistake, perhaps a commit intended for a
local repository. Why else increase the workload, without
discussion with other target maintainers known to risk being
affected by this change? The somewhat obvious fix is to just
revert revision r205810.
CC to committer and author from ChangeLog.
Ok to commit?
libstdc++:
* testsuite/20_util/hash/chi2_quality.cc: Revert previous change.
Index: testsuite/20_util/hash/chi2_quality.cc
===================================================================
--- testsuite/20_util/hash/chi2_quality.cc (revision 205810)
+++ testsuite/20_util/hash/chi2_quality.cc (revision 205809)
@@ -1,7 +1,7 @@
// { dg-options "-std=gnu++0x" }
// Use smaller statistics when running on simulators, so it takes less time.
-// { dg-options "-std=gnu++0x -DSAMPLES=30000" { target simulator } }
+// { dg-options "-std=gnu++0x -DSAMPLES=10000" { target simulator } }
// Copyright (C) 2010-2013 Free Software Foundation, Inc.
//
brgds, H-P