This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: New tsan tests.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>, gcc-patches at gcc dot gnu dot org, Slava Garbuzov <v dot garbuzov at samsung dot com>, "'Evgeny Gavrin'" <e dot gavrin at samsung dot com>
- Date: Wed, 11 Dec 2013 12:07:20 +0100
- Subject: Re: New tsan tests.
- Authentication-results: sourceware.org; auth=none
- References: <52A83A93 dot 7020903 at partner dot samsung dot com> <20131211102352 dot GD892 at tucnak dot redhat dot com> <52A846F2 dot 4060907 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Dec 11, 2013 at 03:05:22PM +0400, Yury Gribov wrote:
> > This test would fail on strict alignment targets.
>
> Ok, we'll throw in a dg-skip-if.
>
> > Why is the test C++ only though?
> > Again, why C++ only?
> > Ditto.
> > Likewise.
>
> I think main reason is having same versions of code with Clang. I
> had an impression that minimization of changes would be preferred
> and C vs. C++ should not make much difference for TSan anyway.
>
> We can convert the tests if necessary though.
I guess I can live with it as is, just was wondering why the tests
were written so carelessly that when they don't really need to test
any C++ features they are still written in C++.
Jakub