This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix tsan tests.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Slava Garbuzov <v dot garbuzov at samsung dot com>
- Date: Tue, 10 Dec 2013 16:37:20 +0100
- Subject: Re: Fix tsan tests.
- Authentication-results: sourceware.org; auth=none
- References: <52A6E359 dot 1090201 at partner dot samsung dot com> <20131210094930 dot GN892 at tucnak dot redhat dot com> <52A6F096 dot 5010307 at samsung dot com> <CAMe9rOoku3gKbMxaYrbp1E+3_iz6Pdrh7Hts+j4nL-yZ9_pA7A at mail dot gmail dot com> <20131210131835 dot GS892 at tucnak dot redhat dot com> <52A72DED dot 7000707 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Dec 10, 2013 at 07:06:21PM +0400, Yury Gribov wrote:
> --- a/gcc/testsuite/g++.dg/tsan/tsan.exp
> +++ b/gcc/testsuite/g++.dg/tsan/tsan.exp
> @@ -42,5 +42,6 @@ gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c $srcdir/c-c++-common
> }
>
> # All done.
> +torture-finish
> tsan_finish
> dg-finish
> diff --git a/gcc/testsuite/gcc.dg/tsan/tsan.exp b/gcc/testsuite/gcc.dg/tsan/tsan.exp
> index a4a5b72..c70021c 100644
> --- a/gcc/testsuite/gcc.dg/tsan/tsan.exp
> +++ b/gcc/testsuite/gcc.dg/tsan/tsan.exp
> @@ -42,5 +42,6 @@ gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c $srcdir/c-c++-common
> }
>
> # All done.
> +torture-finish
> tsan_finish
> dg-finish
I'd prefer to put torture-finish after tsan_finish, so that
destruction is done in reverse order from construction.
Ok with that change.
> 2013-12-10 Yury Gribov <y.gribov@samsung.com>
>
> * gcc-dg/tsan/tsan.exp: Added missing call to torture-finish.
> * g++-dg/tsan/tsan.exp: Likewise.
Jakub