This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix gnat.dg/pack19.adb on some platforms
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 Dec 2013 00:17:07 +0100
- Subject: Re: [patch] Fix gnat.dg/pack19.adb on some platforms
- Authentication-results: sourceware.org; auth=none
- References: <14008801 dot HoYYt5Iu7g at polaris> <2381301 dot D8dW9bNiU2 at polaris> <52A649CB dot 8030101 at redhat dot com>
> Ugh. I don't care that much :-) If you want to handle it, go ahead. I
> would suggest a comment indicating why we've chosen to handle it.
OK, I can do that.
> The only question left is would it be better to handle it in
> extract_bit_field to catch other cases, or is that too late?
I put it there because there is a similar bitsize == 0 case just above:
if (ext_mode == BLKmode)
{
if (target == 0)
target = assign_temp (type, 1, 1);
if (bitsize == 0)
return target;
Not clear how we can reach here though, I could add a comment if I find. :-)
--
Eric Botcazou