This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 3 libstdc++ tests fail at random


On 7 December 2013 17:28, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Dec 7, 2013 at 9:26 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Sat, Dec 7, 2013 at 9:09 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>>> >FAIL: 30_threads/async/async.cc execution test
>>>
>>> async.exe: /usr/src/gcc/libstdc++-v3/testsuite/30_threads/async/async.cc:66: void test02(): Assertion `status == std::future_status::ready' failed.
>>>
>>> This one fails pretty frequently for me, 6 times out of last 12 i686-linux
>>
>> Same here.
>>
>>> bootstraps/regtests, starting with ~ Nov 21th bootstrap (but before that
>>
>> It started for me around revision 205144.
>>
>
> http://gcc.gnu.org/ml/gcc-cvs/2013-11/msg00869.html
>
> changed 30_threads/async/async.cc.

My recent change to that test introduced a race, the main thread could
wake up and check for readiness before the shared state had been made
ready.  Fixed by this patch.

Tested x86_64-linux and i686-linux, committed to trunk.

2013-12-08  Jonathan Wakely  <jwakely.gcc@gmail.com>

        * testsuite/30_threads/async/async.cc: Fix race condition in test.

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]