This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix small vtable verification bugs.

From: Jeff Law <law at redhat dot com>
To: Caroline Tice <cmtice at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 06 Dec 2013 13:48:07 -0700
Subject: Re: [PATCH] Fix small vtable verification bugs.
Authentication-results: sourceware.org; auth=none
References: <CABtf2+TCcgL+cRBAR9Ww528OWvsCQNwmpwNPi8e4DKZX4ihO3A at mail dot gmail dot com>

On 12/06/13 12:30, Caroline Tice wrote:

The attached  patch fixes two small problems with the current vtable
verification code:  it makes the libvtv function decls globally
visible, and it  updates all uses of the verified vtable pointer with
the verification results, rather than just the first use.

I have bootstrapped the compiler with this patch, both with and
without vtable verification enabled, and have run the regression
testsuites, both with and without vtable verification enabled, with no
regressions.  I have only tested this on Linux.

Is this patch OK to commit?

-- Caroline Tice
cmtice@google.com

gcc ChangeLog:

2013-12-06  Caroline Tice  <cmtice@google.com>

         Submitting patch from Stephen Checkoway, s@cs.jhu.edu
         * vtable-class-hierarchy.c (init_functions): Make the libvtv
function decls externally visible.


gcc/cp ChangeLog:

2013-12-06  Caroline Tice  <cmtice@google.com>

         Submitting patch from Stephen Checkoway, s@cs.jhu.edu
         * vtable-class-hierarchy.c (init_functions): Make the libvtv
         function decls externally visible.

OK.
jeff

References:
- [PATCH] Fix small vtable verification bugs.
  - From: Caroline Tice

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]