This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [buildrobot] Re: [PATCH] Split -fisolate-erroneous-paths into two options
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>, Ian Lance Taylor <iant at google dot com>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 5 Dec 2013 10:00:19 +0100
- Subject: Re: [buildrobot] Re: [PATCH] Split -fisolate-erroneous-paths into two options
- Authentication-results: sourceware.org; auth=none
- References: <529FF0C1 dot 3090406 at redhat dot com> <20131205081829 dot GZ30563 at lug-owl dot de>
On Thu, Dec 5, 2013 at 9:18 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Wed, 2013-12-04 20:19:29 -0700, Jeff Law <law@redhat.com> wrote:
>> This patch splits up the erroneous path optimization into two
>> pieces. One which detects NULL dereferences and isolates those paths
>> and a second which detects passing/returning a NULL pointer in cases
>> where an attribute says a non-NULL value is required.
> [...]
>
> This seems to break Go, see eg.
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=50428 :
>
> g++ -c -DDEFAULT_TARGET_VERSION=\"4.9.0\" -DDEFAULT_TARGET_MACHINE=\"i686-pc-linux-gnu\" -DIN_GCC_FRONTEND -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -Igo -I../../../gcc/gcc -I../../../gcc/gcc/go -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/bid -I../libdecnumber -I../../../gcc/gcc/../libbacktrace -o go/go-lang.o -MT go/go-lang.o -MMD -MP -MF go/.deps/go-lang.TPo ../../../gcc/gcc/go/go-lang.c
> ../../../gcc/gcc/go/go-lang.c: In function ‘bool go_langhook_post_options(const char**)’:
> ../../../gcc/gcc/go/go-lang.c:276:27: error: ‘struct gcc_options’ has no member named ‘x_flag_isolate_erroneous_paths’
> if (!global_options_set.x_flag_isolate_erroneous_paths)
> ^
> ../../../gcc/gcc/go/go-lang.c:277:20: error: ‘struct gcc_options’ has no member named ‘x_flag_isolate_erroneous_paths’
> global_options.x_flag_isolate_erroneous_paths = 0;
> ^
> make[2]: *** [go/go-lang.o] Error 1
Seems to me that is a left-over that should have been removed after
the non-call-exception stuff was fixed.
Richard.
> MfG, JBG
>
> --
> Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
> Signature of: http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
> the second :