This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [wwwdocs] Update obvious fix commit policy


On 12/04/13 07:20, Diego Novillo wrote:
On Tue, Dec 3, 2013 at 6:55 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
On Thu, 28 Nov 2013, Richard Biener wrote:
Why remove ChangeLog files, web pages and comments?

I was going to complain about web pages being removed. :-)

On Thu, 28 Nov 2013, Diego Novillo wrote:
-<p>Fixes for obvious typos in ChangeLog files, docs, web pages, comments
-and similar stuff.  Just check in the fix and copy it to
-<code>gcc-patches</code>.  We don't want to get overly anal-retentive
-about checkin policies.</p>
+<p>Obvious fixes can be committed without prior approval.  Just check
+in the fix and copy it to <code>gcc-patches</code>.  A good test to
+determine whether a fix is obvious: <q>will the person who objects to
+my work the most be able to find a fault with my fix?</q>  If the fix
+is later found to be faulty, it can always be rolled back.  We don't
+want to get overly restrictive about checkin policies.</p>

I am in favor of this change.

To some extent, this is more a clarification of what I have seen as
our current policy than a change in policy, though to a laywer-minded
person it surely looks like the latter.  Not sure what kind of approval
this needs?  Mind it has.

I have not received any feedback against this change. I will wait
another 48 hours and commit.
Here's feedback.  Install it now :-)

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]