This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 3 Dec 2013 09:05:53 -0500
- Subject: Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2
- Authentication-results: sourceware.org; auth=none
- References: <20131116114805 dot GJ22514 at bubble dot grove dot modra dot org> <20131117062503 dot GS22514 at bubble dot grove dot modra dot org> <CAGWvnyne6hREz998vu3y+JV-+RGug8jUXR6-KgmXXvHa7UOR+A at mail dot gmail dot com> <20131117144324 dot GT22514 at bubble dot grove dot modra dot org> <20131122025720 dot GE3588 at bubble dot grove dot modra dot org>
On Thu, Nov 21, 2013 at 9:57 PM, Alan Modra <amodra@gmail.com> wrote:
> David,
> Here comes the inevitable followup.. I broke backwards compatibility
> when adding an extra field to ffi_cif. I'd like to import again from
> upstream, where I've already fixed the problem.
>
> https://sourceware.org/ml/libffi-discuss/2013/msg00220.html
>
> Actually, it's not a straight import because many files outside of
> libffi/src/powerpc/ have diverged, but fortunately for me, not
> significantly. For the record, I've shown the files that need
> patching below. Identical patches went in upstream (except for
> formatting differences in Makefile.am). Bootstrapped etc.
> powerpc64-linux and powerpc64le-linux. OK to apply?
>
> libffi/
> * src/powerpc/ffitarget.h: Import from upstream.
> * src/powerpc/ffi_powerpc.h: Likewise.
> * src/powerpc/ffi.c: Likewise.
> * src/powerpc/ffi_sysv.c: Likewise.
> * src/powerpc/ffi_linux64.c: Likewise.
> * src/powerpc/sysv.S: Likewise.
> * src/powerpc/ppc_closure.S: Likewise.
> * src/powerpc/linux64.S: Likewise.
> * src/powerpc/linux64_closure.S: Likewise.
> * src/types.c: Likewise.
> * Makefile.am (EXTRA_DIST): Add new src/powerpc files.
> (nodist_libffi_la_SOURCES <POWERPC, POWERPC_FREEBSD>): Likewise.
> * configure.ac (HAVE_LONG_DOUBLE_VARIANT): Define for powerpc.
> * include/ffi.h.in (ffi_prep_types): Declare.
> * src/prep_cif.c (ffi_prep_cif_core): Call ffi_prep_types.
> * configure: Regenerate.
> * fficonfig.h.in: Regenerate.
> * Makefile.in: Regenerate.
> * man/Makefile.in: Regenerate.
> * include/Makefile.in: Regenerate.
> * testsuite/Makefile.in: Regenerate.
Have you tested this patch on targets other than powerpc-linux? Have
you tested this patch on AIX?
- David