This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix checking of gimple types
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Nov 2013 21:27:06 -0500
- Subject: Re: [PATCH] Fix checking of gimple types
- Authentication-results: sourceware.org; auth=none
- References: <5271CBF9 dot 2070005 at redhat dot com> <1383236801-13234-1-git-send-email-dmalcolm at redhat dot com> <1383236801-13234-4-git-send-email-dmalcolm at redhat dot com> <5284806A dot 2050607 at redhat dot com> <1384806352 dot 11568 dot 80 dot camel at surprise> <20131121221933 dot GQ892 at tucnak dot redhat dot com> <528E8837 dot 5080300 at redhat dot com> <20131121224257 dot GR892 at tucnak dot redhat dot com> <528E9135 dot 7060408 at redhat dot com> <1385393718 dot 11568 dot 266 dot camel at surprise> <5293A62B dot 4060706 at redhat dot com>
On Mon, 2013-11-25 at 12:34 -0700, Jeff Law wrote:
> On 11/25/13 08:35, David Malcolm wrote:
> >
> > I'm not a fan of these "_layout" names, but I'm not sure what better to
> > call them. Perhaps:
> > GSS_OMP_PARALLEL_LAYOUT -> GSS_OMP_WITH_CLAUSES_CHILD_FN_DATA_ARG
> > GSS_OMP_SINGLE_LAYOUT -> GSS_OMP_WITH_CLAUSES
> > GSS_OMP_ATOMIC_STORE_LAYOUT -> GSS_OMP_WITHOUT_SEQ_WITH_VAL
> > with analogous names for the corresponding structs.
> I think the _layout names are fine for now. We might want change them
> to be more descriptive at a later date.
>
> >
> > OK for trunk?
> Yes.
Thanks; committed to trunk as r205428.