This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [SH] Pass --isa to assembler
- From: Oleg Endo <oleg dot endo at t-online dot de>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 25 Nov 2013 18:13:11 +0100
- Subject: Re: [SH] Pass --isa to assembler
- Authentication-results: sourceware.org; auth=none
- References: <1385316317 dot 2438 dot 287 dot camel at yam-132-YW-E178-FTW> <20131125 dot 091243 dot 163789287 dot kkojima at rr dot iij4u dot or dot jp>
On Mon, 2013-11-25 at 09:12 +0900, Kaz Kojima wrote:
> Oleg Endo <oleg.endo@t-online.de> wrote:
> > Currently GCC doesn't pass the --isa parameter to the assembler for SH
> > targets other than SH2A and SH5. This makes the assembler accept any
> > kind of ISA and happily produce e.g. SH2A code even though the target is
> > SH4, which will then fail to link.
> > The attach patch fixes this by passing the --isa parameter also for -m1,
> > -m2*, -m3*, and -m4*.
> > It also caught a mistake in libgcc/crt1.S, where the SH3 / SH4 VBR setup
> > code was compiled for SH2E.
> >
> > Tested with
> > make -k -j4 check RUNTESTFLAGS="--target_board=sh-sim
> > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}"
> >
> > and no new failures.
> > OK for trunk?
>
> libgcc fix should be an independent patch and is OK for trunk
> as an obvious fix. --isa part looks fine but is a new feature.
> It's OK when trunk goes back to stage1.
OK, I've committed the libgcc fix as rev 205360.
Cheers,
Oleg