This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Generate correct constant permutes using xxpermdi
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 22 Nov 2013 22:19:15 -0500
- Subject: Re: [PATCH, rs6000] Generate correct constant permutes using xxpermdi
- Authentication-results: sourceware.org; auth=none
- References: <1385134908 dot 3052 dot 4 dot camel at gnopaine>
On Fri, Nov 22, 2013 at 10:41 AM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> Most of our constant vector permutes use the vperm instructions, but for
> V2DImode and V2DFmode we use xxpermdi. This patch corrects the
> generated xxpermdi to be correct for little endian, which fixes failures
> of the test cases gcc.dg/torture/vshuf-v2d[fi].c. Note that we can't
> fix this directly in the pattern for xxpermdi, because that pattern is
> used by the corresponding intrinsic.
>
> Bootstrapped and tested on powerpc64{,le}-unknown-linux-gnu with no
> regressions. Ok for trunk?
>
> Thanks,
> Bill
>
>
> 2013-11-22 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.c (rs6000_expand_vec_perm_const_1): Correct
> for little endian.
Okay.
The instrinsic could use a separate, dedicated pattern.
Thanks, David