This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: three problems with stor-layout.c.


On Thu, 21 Nov 2013, Kenneth Zadeck wrote:

> Richi,
> 
> Here is the patch.   As you can see, i chose the unsigned option.
> It was bootstrapped and tested on x86 with all languages including ada.
> Ok to commit?

Ok.

Thanks,
Richard.

> kenny
> 
> 2013-11-21  zadeck@naturalbridge.com
>     * store-layout.c
>     (place-field): Fix hwi test and accessor mismatch.
> 
> 
> 
> 
> On 11/21/2013 11:07 AM, Eric Botcazou wrote:
> > > I think most of these are because in the past (yes I have fixed that!!)
> > > all 'sizetype' constants were sign-extended (and the signedness,
> > > that is, TYPE_UNSIGNED (sizetype), was frontend dependend (ugh) and
> > > then later true, thus unsigned).
> > > 
> > > So I think all _SIZE stuff should check fits_uhwi_p and be used as
> > > uhwi.  But that may have ripple-down effects, so consistently
> > > using fits_shwi_p and using as shwi is also fine (it just restricts
> > > the maximum values we accept(?)).
> > And please make sure to test Ada if you're tweaking this, it's fragile
> > stuff.
> > 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]