This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [fortran, patch] Add Fortran 2003 IEEE intrinsic modules


Hi FX,

some first remarks.

FX wrote:
> I would like to get testing from:
>   â a Solaris target (to test config/fpu-sysv.h)
>  â an AIX target (to test config/fpu-aix.h)

For AIX, you could ask David Edelsohn for review.

For x87/SSE, you could ask Uros Bizjak for review.

For SysV you could ask Gerald Pfeifer (FreeBSD) and Eric Botcazou (Solaris)
for testing. (As libgfortran/config patching has shown, the two systems can
have different definitions.)


> --- gcc/testsuite/lib/target-supports.exp	(revision 205019)
> +++ gcc/testsuite/lib/target-supports.exp	(working copy)
>  proc add_options_for_ieee { flags } {
...
> +    set extra "-fno-unsafe-math-optimizations -frounding-math -fsignaling-nans -fintrinsic-modules-path $specpath/libgfortran/"

That part looks wrong: I think you do not want to add -fintrinsic-modules-path
for all IEEE functions, e.g. C and C++ compilers do not handle that option,
nor does the Ada compiler.

You could also ask Mike Stump to review the testsuite changes.


> --- libgfortran/gfortran.map	(revision 205019)
> +++ libgfortran/gfortran.map	(working copy)
> @@ -1193,6 +1193,97 @@ GFORTRAN_1.5 {
>   global:
>     _gfortran_ftell2;
>     _gfortran_backtrace;
>+    _gfortran_ieee_copy_sign_4_4_;


GFORTRAN_1.5 was used by GCC 4.8. You should start a new section
when you want to add symbols for a new release.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]