This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Privatize gimplify_ctx structure.

From: Jeff Law <law at redhat dot com>
To: Andrew MacLeod <amacleod at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Diego Novillo <dnovillo at google dot com>
Date: Wed, 20 Nov 2013 09:53:23 -0700
Subject: Re: [patch] Privatize gimplify_ctx structure.
Authentication-results: sourceware.org; auth=none
References: <528CBAA0 dot 5060801 at redhat dot com> <20131120134434 dot GH892 at tucnak dot redhat dot com> <528CBF9E dot 1090302 at redhat dot com>

On 11/20/13 06:56, Andrew MacLeod wrote:

On 11/20/2013 08:44 AM, Jakub Jelinek wrote:

On Wed, Nov 20, 2013 at 08:35:28AM -0500, Andrew MacLeod wrote:

I also hacked up the compiler to report what the 'top' of the stack
was for a compilation unit. I then ran it through a bootstrap and
full testsuite run of all languages, and looked for the maximum
number of context structs in use at one time.  Normally only 1 or 2
were ever in use, but its topped out at 7 during some of the openmp
tests.  So my current limit of 30 will likely never been reached.

???  You can trivially create a testcase where it will be reached
(and you certainly should, so that you actually test the fallback).


Not something we're likely to see every day, but excellent!  a testcase
is good :-) I'll add this as a testcase.

Do you think the current limit of 30 is reasonable?

Yes if you've verified the fall back works ;-) You probably could evendrop it to 10ish.

jeff

References:
- [patch] Privatize gimplify_ctx structure.
  - From: Andrew MacLeod
- Re: [patch] Privatize gimplify_ctx structure.
  - From: Jakub Jelinek
- Re: [patch] Privatize gimplify_ctx structure.
  - From: Andrew MacLeod

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]