This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64] vneg testcase made big-endian safe
- From: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- To: Alex Velenko <Alex dot Velenko at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 20 Nov 2013 16:07:26 +0000
- Subject: Re: [PATCH][AArch64] vneg testcase made big-endian safe
- Authentication-results: sourceware.org; auth=none
- References: <528B9FFA dot 30304 at arm dot com>
On 19/11/13 17:29, Alex Velenko wrote:
gcc/testsuite/
2013-11-19 Alex Velenko <Alex.Velenko@arm.com>
* gcc.target/aarch64/vneg_s.c (test_vneg_s8): fixed to not use
vector indexing.
(test_vneg_s16): Likewise.
(test_vneg_s32): Likewise.
(test_vneg_s64): Likewise.
(test_vnegq_s8): Likewise.
(test_vnegq_s16): Likewise.
(test_vnegq_s32): Likewise.
(test_vnegq_s64): Likewise.
Hi, Couple of nits:
-#define RUN_TEST(test_set, answ_set, reg_len, data_len, n, a, b) \
- { \
+#define RUN_TEST(test_set, answ_set, reg_len, \
+ data_len, n, a, b, _a, _b) \
+{ \
This part of the patch changes the indentation for the body of RUN_TEST
unnecessarily, please re-indent.
- int16x4_t a;
- int16x4_t b;
+ int16x4_t a, b;
Unnecessary layout change, please remove.
The ChangeLog should provide a detailed explanation of what changed.
For example:
* gcc.target/aarch64/vneg_s.c (LANE_POSTFIX): New.
(INDEX64_8, INDEX64_16, INDEX64_32, INDEX64_64, INDEX128_8)
(INDEX128_16, INDEX128_32, INDEX128_64, INDEX): Removed.
(RUN_TEST): New formal arguments _a and _b.......
(test_vneg_s8): Define _a and _b. Pass to RUN_TEST.
...
etc
Cheers
/Marcus