This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386, MPX, 3/X] MPX tests
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 20 Nov 2013 02:05:28 +0400
- Subject: Re: [PATCH, i386, MPX, 3/X] MPX tests
- Authentication-results: sourceware.org; auth=none
- References: <20131119205849 dot GX21297 at msticlxl57 dot ims dot intel dot com> <Pine dot LNX dot 4 dot 64 dot 1311192156430 dot 8742 at digraph dot polyomino dot org dot uk>
2013/11/20 Joseph S. Myers <joseph@codesourcery.com>:
> On Wed, 20 Nov 2013, Ilya Enkovich wrote:
>
>> Here is a patch to add MPX tests.
>
> I don't think these should be under gcc.target/i386; gcc.dg/mpx would be
> better, so if someone adds a corresponding feature for another target,
> they don't need to move all the tests around.
All tests use target specific option -mmpx. Shouldn't it go into
target tests then?
>
> Anything added that's XFAILed should have a comment explaining the reason
> for the XFAILing (a reference to a bug in GCC Bugzilla is a good idea,
> with that bug then mentioning the particular test that indicates whether
> the bug is still present).
Tests fail not due to the bug but because these tests should fail. It
would mean bound violation was detected.
Ilya
>
> --
> Joseph S. Myers
> joseph@codesourcery.com