This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection


On Tue, 19 Nov 2013, Jakub Jelinek wrote:

> On Tue, Nov 19, 2013 at 04:30:21PM +0530, Venkataramanan Kumar wrote:
> > This is RFC patch that adds machine descriptions to support stack
> > smashing protection in AArch64.
> 
> Most of the testsuite changes look wrong.  The fact that aarch64
> gets stack protector support doesn't mean all other targets do as well.
> So please leave all the changes that remove native or stack_protector
> requirements out.

The tests for "target native" look wrong for me ("native" conditionals 
only make sense for special cases such as guality tests that expect to 
exec another tool on the host) - so I think they should be removed, but 
that removal needs submitting as a separate patch.

I would like to see a clear description of what happens with all eight 
combinations of (glibc version does or doesn't support this, GCC building 
glibc does or doesn't support this, GCC building user program does or 
doesn't support this).  Which of the (GCC building glibc, glibc) 
combinations will successfully build glibc?  Will all such glibcs be 
binary-compatible?  Will both old and new GCC work for building user 
programs with both old and new glibc?

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]