This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Please don't commit changes to gcc/go/gofrontend
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, rsandiford at googlemail dot com, gcc-patches <gcc-patches at gcc dot gnu dot org>, Dave Cheney <dave at cheney dot net>
- Date: Tue, 19 Nov 2013 15:17:21 +0000
- Subject: Re: Please don't commit changes to gcc/go/gofrontend
- Authentication-results: sourceware.org; auth=none
- References: <CAKOQZ8wdPgL2ZO87LLiiOuSSpaxxnHwvW0YRxD_hbySg-ANEHg at mail dot gmail dot com> <CAD_=9DSGhnDS-5dpiXaynJ8h-KQg0vpPfdEec5RzZXyFoK8n_Q at mail dot gmail dot com>
Diego Novillo <dnovillo@google.com> writes:
> On Tue, Nov 19, 2013 at 9:48 AM, Ian Lance Taylor <iant@google.com> wrote:
>> Hi, as noted in gcc/go/README.gcc, the files in gcc/go/gofrontend are
>> actually mirrored from a different repository. Please do not directly
>> commit changes to those files. Instead, send the changes to me. I
>> will commit them upstream. Thanks.
>>
>> Ian
>
> Ugh, sorry. This is really counter-intuitive. To properly test
> changes, one needs the patch in the tree. So when I do the final
> commit, it is not easy to remember that I need to take it out (and
> taking it out means undoing a local commit, which is yet another
> operation).
>
> Sorry, but I would expect these problems to continue. Is it possible
> for you to cope in some other way? Like your merging script noticing
> changes and incorporating them into your tree?
>
> Alternately, would it be possible to install some kind of svn hook
> that only allows certain users to commit?
+1 FWIW. I think anyone making an interface change is going to assume
that they should update all in-tree users. It's unusual to say that
people should knowingly break the build.
Thanks,
Richard