This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Konstantin Serebryany <kcc at gcc dot gnu dot org>, Alexey Samsonov <samsonovatgoogledotcom at zalov dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Nov 2013 15:46:57 +0100
- Subject: Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer
- Authentication-results: sourceware.org; auth=none
- References: <20131118133930 dot GA892 at tucnak dot redhat dot com> <CAKOQZ8zS+eexJA0b3Wtg3RXDCjE8An_knyrFcymcJoCBwD4=ZQ at mail dot gmail dot com> <20131119080410 dot GN892 at tucnak dot redhat dot com> <CAKOQZ8zGg=ji3uPwNLTKQ9do05GuVebCHaFiN2Ybt5PW4v5-tQ at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Nov 19, 2013 at 06:43:07AM -0800, Ian Lance Taylor wrote:
> > 2013-11-19 Jakub Jelinek <jakub@redhat.com>
> >
> > * backtrace.h (backtrace_syminfo_callback): Add symsize argument.
> > * elf.c (elf_syminfo): Pass 0 or sym->size to the callback as
> > last argument.
> > * btest.c (struct symdata): Add size field.
> > (callback_three): Add symsize argument. Copy it to the data->size
> > field.
> > (f23): Set symdata.size to 0.
> > (test5): Likewise. If sizeof (int) > 1, lookup address of
> > ((uintptr_t) &global) + 1. Verify symdata.val and symdata.size
> > values.
>
> This is OK.
>
> I will take care of libgo when this is committed.
Ok, thanks, in now (== r205028).
Jakub