This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA/RFC patch]: Follow-up on type-demotion pass ...
- From: Kai Tietz <ktietz at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Nov 2013 05:28:45 -0500 (EST)
- Subject: Re: [RFA/RFC patch]: Follow-up on type-demotion pass ...
- Authentication-results: sourceware.org; auth=none
- References: <317948312 dot 36384059 dot 1384803974853 dot JavaMail dot root at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1311182252140 dot 8831 at digraph dot polyomino dot org dot uk>
----- Original Message -----
> This is not a review, but:
>
> * What do you need from rtl.h? It's generally best for GIMPLE passes to
> avoid rtl.h where possible (and if you can avoid it, the next question is
> whether you can also avoid tm.h).
Yes, for now rtl.h, tm.h and tm_p.h headers can be avoided. The first two are required for tm_p.h header. As this patch doesn't requires target-hooks, I removed those three includes from my local patch.
> * Going just on the general description of the pass and not looking at the
> details: does this do any of the things that are done by shorten_binary_op
> or shorten_compare in c-common.c? If so, do you plan followup changes to
> remove as premature optimizations whatever those functions do that can be
> done by this pass?
I didn't had explicit shorten_compare and/or shorten_binary_op on radar, but on a closer look into them, yes. This patch is a step into this area.
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>
Kai