This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] S/390: More htm testcases plus some fixes
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, vogt at linux dot vnet dot ibm dot com
- Date: Mon, 18 Nov 2013 10:09:44 -0600
- Subject: Re: [PATCH] S/390: More htm testcases plus some fixes
- Authentication-results: sourceware.org; auth=none
- References: <20131118090514 dot GA11649 at bart>
On Mon, 2013-11-18 at 10:05 +0100, Andreas Krebbel wrote:
> With the patch the htm-nofloat-2 testcase fails. Due to the
> "returns_twice" flag on tbegin the optimizers fail to fold the
> compares of the condition code and the s390_optimize_nonescaping_tx
> routine in turn fails to optimize the simple transactions. This will
> hopefully be fixed with a follow-on patch.
Hi Andreas,
I assume you're using the returns_twice attribute on your tbegin builtin
so that the compiler will help you with the handling of the floating
point registers since they are not restored on the s390's transaction
failure? We don't have that attribute set on POWER's tbegin builtin
and I don't think we should since all of our registers are restored
on a transaction failure, but I'd like to know if you added that
attribute for any other reason such that POWER should have it too?
Peter