This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix lto-profiledbootstrap [was: Merge cgraph_get_create_node and cgraph_get_create_real_symbol_node]


> On Fri, Nov 15, 2013 at 12:46 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> >> > 2013-11-14  Uros Bizjak  <ubizjak@gmail.com>
> >> >
> >> >     * lto-streamer-in.c (input function): Call cgraph_create_node if
> >> >     cgraph_get_node failed.
> >> >
> >> > Tested with lto-profiledbootstrap on x86_64-pc-linux-gnu, regression
> >> > tested also with -m32 [1].
> >> >
> >> > OK for mainline?
> >
> > OK (though it is a bit ugly - but lto streaming is very much a special case),
> > thanks!
> 
> Why would the cgraph node be not present when we input the body!?
> Isn't there a bug elsewhere??
> 
> IMHO this just papers over an issue.

Hmm, right, I misread it to be lto-cgraph.c instead (where it would make sense,
since we may read nodes previously constructed earlier by decl sharing).

I will look into this.  We should to have nodes present here.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]