This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c


On Thu, Nov 07, 2013 at 06:24:55PM -0800, Cong Hou wrote:
> Ping. OK for the trunk?
> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
> > It seems that on some platforms the loops in
> > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
> > small patch added { dg-require-effective-target vect_int } to make
> > sure all loops can be vectorized.
> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> > index 9d0f4a5..3d9916d 100644
> > --- a/gcc/testsuite/ChangeLog
> > +++ b/gcc/testsuite/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2013-10-29  Cong Hou  <congh@google.com>
> > +
> > +       * gcc.dg/vect/pr58508.c: Update.
> > +
> >  2013-10-15  Cong Hou  <congh@google.com>
> >
> >         * gcc.dg/vect/pr58508.c: New test.
> > diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > index 6484a65..fff7a04 100644
> > --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > @@ -1,3 +1,4 @@
> > +/* { dg-require-effective-target vect_int } */
> >  /* { dg-do compile } */
> >  /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */

This isn't the only bug in the testcase.  Another one is using
dg-options in gcc.dg/vect/, you should just leave that out,
the default options already include those options, but explicit dg-options
mean that other required options like -msse2 on i?86 aren't added.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]