This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.

From: Jason Merrill <jason at redhat dot com>
To: Adam Butcher <adam at jessamine dot co dot uk>
Cc: gcc-patches at gcc dot gnu dot org, Volker Reichelt <reichelt at gcc dot gnu dot org>
Date: Mon, 11 Nov 2013 20:57:11 -0500
Subject: Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
Authentication-results: sourceware.org; auth=none
References: <1383212824-5493-1-git-send-email-adam at jessamine dot co dot uk> <1383212824-5493-2-git-send-email-adam at jessamine dot co dot uk> <527D328D dot 9010800 at redhat dot com> <48a0350ad377d7ec6de413e61724fe4e at imap dot force9 dot net> <527F2364 dot 3060404 at redhat dot com> <eeb21f1c72dc9516d005e36bee93d3ae at imap dot force9 dot net> <83aee761b3c92ffde735b75897c75ff0 at imap dot force9 dot net> <527FD52F dot 6090708 at redhat dot com> <e00ecd81bd8720e2bdafd87b87dd6522 at imap dot force9 dot net> <52801507 dot 80900 at redhat dot com> <cf00d97be2abc78828bccb4a3c6294cd at imap dot force9 dot net>

On 11/11/2013 02:44 PM, Adam Butcher wrote:

Yes, using add_outermost_template_args.

I have done this (diff -w -b follows).  The route to this seems even
more costly though; current_template_parms needs to first be converted
to a vec by current_template_args() then the last nesting level is
thrown away and replaced with the one we're working on.

True. It looks like you could avoid the wasted conversion of theinnermost level by doing


template_parms_to_args (TREE_CHAIN (current_template_parms))

rather than

current_template_args.

The patch is OK with or without that change.

Jason

References:
- Re: [SKETCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- [C++ PATCH 1/3] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Jason Merrill
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Jason Merrill
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Jason Merrill
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Jason Merrill
- Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.
  - From: Adam Butcher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]