This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR ada/35998


On Mon, Nov 11, 2013 at 11:10 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> Hi,
>
> this is an old bug report from Jan, which was closed, then reopened by Tom at
> some point, but the patch never got reviewed.  The original submission is at:
>   http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01857.html
>
> Tested on x86_64-suse-linux, OK for the mainline?

Due to the different interfaces of int_size_in_bytes and
simple_type_size_in_bits (and 'size' in add_byte_size_attribute being
unsigned and not [unsigned] HWI) it would be cleaner to
add an early return after the call to int_size_in_bytes if its
return value is -1 (and make sure the return value doesn't
overflow an unsigned int - likewise for simple_type_size_in_bits,
not sure why that case doesn't use int_size_in_bytes as well ...)?

Can you apply some TLC here?

Thanks,
Richard.

>
> 2013-11-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         PR ada/35998
>         * dwarf2out.c (add_byte_size_attribute): Omit attribute for size -1.
>
>
> --
> Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]