This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] libgcov.c re-factoring and offline profile-tool
- From: Rong Xu <xur at google dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Xinliang David Li <davidxl at google dot com>, Jakub Jelinek <jakub at redhat dot com>, Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 7 Nov 2013 15:34:57 -0800
- Subject: Re: [RFC] libgcov.c re-factoring and offline profile-tool
- Authentication-results: sourceware.org; auth=none
- References: <CAF1bQ=Qy6--WX-bLYZ8aWXjVVu4pW-H3U+PkATgXwg5c7MZsBg at mail dot gmail dot com> <CAAkRFZ+-tLZqUNQRtu7jN3d3BYG8oi-+q0J6pkduHp5GS3oTkQ at mail dot gmail dot com> <20131104095529 dot GB28992 at kam dot mff dot cuni dot cz> <CAF1bQ=THYY8NqoJ0XDYxnFS9=j9P6-5nLwA6nX1bA+0v1zmUoQ at mail dot gmail dot com> <CAAkRFZK-AoS4eKBnoNciHeq5kn5sP60rqyV1dVZVaBte1aW-ew at mail dot gmail dot com> <20131105091850 dot GB13502 at kam dot mff dot cuni dot cz> <20131105092344 dot GF27813 at tucnak dot zalov dot cz> <CAAkRFZK0G61tYeMeVcoOETxhhDWZNnh1Eyf0jeKrTAvsAtZE=A at mail dot gmail dot com> <CAF1bQ=S8m03771H=O7H90mbsCrt1tcknktWYGFCdRF4O-MyF-Q at mail dot gmail dot com> <CAAkRFZ+Be51E2PFPULbNmAh9qQigWTqa04wi8S19ZrPiPwVPiA at mail dot gmail dot com> <CAF1bQ=TyLYDqaWZH3tEw-YODoJMBmt0VVyFaf2+sft2vAxwF_Q at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1311070108410 dot 3878 at digraph dot polyomino dot org dot uk> <CAF1bQ=REYRgX4zn2pwP0HZhg5P0nO3XgXVK=RQVBpFv-o5zoig at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1311071739500 dot 20971 at digraph dot polyomino dot org dot uk>
On Thu, Nov 7, 2013 at 9:40 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 7 Nov 2013, Rong Xu wrote:
>
>> Thanks Joseph for these detailed comments/suggestions.
>> The fixed patch is attached to this email.
>> The only thing left out is the Texinfo manual. Do you mean this tool
>> should have its it's own texi file in gcc/doc?
>
> Its own texi file, probably included as a chapter by gcc.texi (like
> gcov.texi is).
OK. will add this in.
My last patch that changes the command handling is actually broken.
Please ignore that patch and use the one in this email.
Also did some minor adjust of the code in libgcov.
Thanks,
-Rong
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
Attachment:
libgcov_patch4.txt
Description: Text document
Attachment:
profile_tool_patch4.txt
Description: Text document