This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Clean up atomic tests


On Nov 7, 2013, at 8:43 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> This patch cleans up various issues with the tests of atomics built-in
> functions and libatomic functions, in preparation for adapting those
> tests to add test coverage of stdatomic.h macros.  The tests were
> missing a return type for main (C11 doesn't allow implicit int return
> types).

Ok for those changes.

> Some tests were incrementing a variable in one part of an
> expression and using its value in another part without a sequence
> point in between.

Ok for those changes.

> And the libatomic tests shouldn't have been
> restricted to targets with hardware sync_* support, or adding
> command-line options to make such support available,

For this I'd like a domain expert to weigh in.  If that is you, then you can check it in as obvious if you'd like.  If you want a review, you can wait for them to speak up.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]