This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re-factor tree.h - Part 1


On Wed, Nov 6, 2013 at 11:54 AM, Jeff Law <law@redhat.com> wrote:
> On 11/06/13 00:04, Marc Glisse wrote:
>>
>> On Tue, 5 Nov 2013, Diego Novillo wrote:
>>
>>> This is the first patch in a series of patches to cleanup tree.h to
>>> reduce the exposure it has all over the compiler.
>>>
>>> In this patch, I'm moving functions that are used once into the files
>>> that use them, and make them private to that file. These functions
>>> were declared extern in tree.h and called from exactly one place.
>>
>>
>> I am not a big fan of doing it so automatically. For instance
>> widest_int_cst_value should imho remain next to int_cst_value since they
>> mostly share the same implementation. Doing this also doesn't promote
>> code reuse: if I am looking for a function that does some basic
>> operation on trees, I won't only need to look in the file that is
>> semantically relevant, I'll also need to randomly grep through possible
>> users to see if I should revert that part of your patch. On the other
>> hand, most of those functions you move probably are better off in their
>> new location, so you can ignore my post.
>
> What I think makes sense is to review what moved and where/why.  I suspect
> (but have not looked) that much of the movement of code makes sense.  Where
> it doesn't, then obviously we shouldn't make that change.

Ah, yes.  I just sent this list.  Perhaps that's easier to discuss
than the patch, which looks like line noise.


Thanks.  Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]