This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [SH] PR 30807 - Add test case
- From: Oleg Endo <oleg dot endo at t-online dot de>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 05 Nov 2013 22:45:59 +0100
- Subject: Re: [SH] PR 30807 - Add test case
- Authentication-results: sourceware.org; auth=none
- References: <1383684273 dot 2445 dot 401 dot camel at yam-132-YW-E178-FTW> <09B1E7B7-796F-4C80-8FAA-1B73140DF759 at comcast dot net>
On Tue, 2013-11-05 at 13:33 -0800, Mike Stump wrote:
> On Nov 5, 2013, at 12:44 PM, Oleg Endo <oleg.endo@t-online.de> wrote:
> > +/* { dg-do compile { target "sh*-*-*" } } */
>
> Why do this, when sh-torture.exp does this:
>
> if { ![istarget sh*-*-*] } then {
> return
> }
>
> ? I suspect you merely copied the style from the other test cases.
Exactly.
> If there isn't a good reason to do this, please don't.
>
You're right, it's redundant. It should be just
/* { dg-do compile } */
shouldn't it?
I can change that before committing, no problem.
I can also fix the other existing SH tests to prevent further copy pasta
as a separate patch.
Cheers,
Oleg