This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [SH] PR 30807 - Add test case
- From: Mike Stump <mikestump at comcast dot net>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Nov 2013 13:33:40 -0800
- Subject: Re: [SH] PR 30807 - Add test case
- Authentication-results: sourceware.org; auth=none
- References: <1383684273 dot 2445 dot 401 dot camel at yam-132-YW-E178-FTW>
On Nov 5, 2013, at 12:44 PM, Oleg Endo <oleg.endo@t-online.de> wrote:
> +/* { dg-do compile { target "sh*-*-*" } } */
Why do this, when sh-torture.exp does this:
if { ![istarget sh*-*-*] } then {
return
}
? I suspect you merely copied the style from the other test cases. If there isn't a good reason to do this, please don't.
Other ports that seem to do this at least to some extent: aarch64, bfin, h8300, ia64, m68k, powerpc, s390 and sh.
If no one has a good reason to do this, I'd ask people to remove target lines that don't shrink in some way the list of targets.
> OK to add?
I'll let the sh folks comment as normal on the rest of it… seems fine to me.