This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

On 11/05/13 10:04, Iyer, Balaji V wrote:
Hello Jakub et al.,
       I went through all your emails and the patch above will fix the following issues:

1. Bug in the fib<>.c test case where it should recursively call fib_serial instead of fib() in the serial case.
2. Remove duplicate or unwanted test case flags (e.g. there were cases were -g and "-O0 -g" were both tested, so I took out one of them)
3. Called builtin_abort() instead of returning a non-zero return value for main in the test cases.
4. Reduce the iteration of fib -- the main reason why I had a larger iteration is that we wanted to force a steal, but I already have a test case that will do that. So, if there is any issue in that logic, that code should fail.

Also, with all these changes, make check-gcc RUNTESTFLAGS='--target_board=unix/-m32 cilk-plus.exp' and make check-gcc RUNTESTFLAGS='--target_board=unix cilk-plus.exp' runs are significantly faster.

Here are the ChangeLog entries:

+2013-11-05  Balaji V. Iyer  <>
+       * c-c++-common/cilk-plus/CK/fib.c: Reduced the iteration from
+       40 to 30.  Replaced iteration variable with a #define.  Instead of
+       returning non-zero value for error, called __builtin_abort ().  Fixed
+       a bug of calling fib_serial in serial case instead of fib.
+       * c-c++-common/cilk-plus/CK/fib_init_expr_xy.c: Likewise.
+       * c-c++-common/cilk-plus/CK/fib_no_return.c: Likewise.
+       * c-c++-common/cilk-plus/CK/fib_no_sync.c: Likewise.
+       * gcc.dg/cilk-plus/cilk-plus.exp: Removed duplicate/un-necessary
+       compiler flag testing.

Is this Ok to check in?

I do wonder if this would be better in the dg-torture framework. But you can investigate that as a follow-up.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]