This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, MPX, 2/X] Pointers Checker [6/25] Instrumentation pass
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Nov 2013 17:45:45 +0400
- Subject: Re: [PATCH, MPX, 2/X] Pointers Checker [6/25] Instrumentation pass
- Authentication-results: sourceware.org; auth=none
- References: <20131031085209 dot GB54327 at msticlxl57 dot ims dot intel dot com> <Pine dot LNX dot 4 dot 64 dot 1311012155410 dot 31271 at digraph dot polyomino dot org dot uk> <20131105111708 dot GG54327 at msticlxl57 dot ims dot intel dot com> <Pine dot LNX dot 4 dot 64 dot 1311051335510 dot 19896 at digraph dot polyomino dot org dot uk>
2013/11/5 Joseph S. Myers <email@example.com>:
> On Tue, 5 Nov 2013, Ilya Enkovich wrote:
>> On 01 Nov 21:59, Joseph S. Myers wrote:
>> > On Thu, 31 Oct 2013, Ilya Enkovich wrote:
>> > > * tree-chkp.c: New.
>> > This file includes tm.h. Inclusion of tm.h in front-end and GIMPLE files
>> > is discouraged (well, we'd like to convert all target macros to hooks, but
>> > the limited subset used in front-end and GIMPLE files are lower-hanging
>> > fruit than eliminating tm.h from the RTL parts of the compiler). If you
>> > need it, please put a comment on the #include saying exactly what target
>> > macros you need, so people know which macros' conversion to hooks would
>> > eliminate the need for the tm.h inclusion.
>> There was a work to remove all target macros from this file. No all
>> target dependencies should go through hooks. Actually I can remove tm.h
>> include from this file but it does not guarantee it is not used because
>> it is implicitly included via expr.h, right?
> So the next question is why this file includes expr.h. It's a tree-*
> file. The presumption is that it should not need anything to do with RTL
> and so shouldn't need to include expr.h, rtl.h or tm.h, directly or
> If there are just a few bits of RTL-related code for this functionality,
> but most of it works on GIMPLE, I'd suggest separating the RTL pieces out
> into a separate file.
It exports some functions manipulating with RTL and used by expand and
target. Iface macros DECL_BOUNDS_RTL and SET_DECL_BOUNDS_RTL also use
rtx type. Should I make two separate .h and .c files or include RTL
part into something existent?
> Joseph S. Myers