This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion, [gnu.org #746725]
- From: Josh Cogliati <jrincayc at yahoo dot com>
- To: "copyright-clerk at fsf dot org" <copyright-clerk at fsf dot org>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, jason at redhat dot com, manu at gcc dot gnu dot org, Dodji Seketeli <dodji at redhat dot com>
- Date: Tue, 5 Nov 2013 04:55:19 -0800 (PST)
- Subject: Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion, [gnu.org #746725]
- Authentication-results: sourceware.org; auth=none
Donald R Robertson III or the current copyright clerk,
Can you check and make sure that my copyright assignment paperwork is finished? I was number: 746725 It should have been received September 20, 2013.
On Tue, 11/5/13, Dodji Seketeli <firstname.lastname@example.org> wrote:
Subject: Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion
To: "Joshua J Cogliati" <email@example.com>
Cc: "Joseph S. Myers" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com
Date: Tuesday, November 5, 2013, 5:12 AM
Sorry for my late reply on this.
I just have one very small nit for one ChangeLog entry,
below. If nobody objects in the next 48 hours, I'd say
this is OK to
commit with the nit fixed.
I am not seeing your name in the MAINTAINERS file.
Have you filed
copyright assignment to the FSF and do you have it all
Joshua J Cogliati <firstname.lastname@example.org>
> Since part of it was to go into c-family (as per Joseph
> email) and parts are not in c-family, I split the
changelog into three
> parts. I also changed the formatting
of the changelog and patch as
> per Dodji's comments. The attached patch is the same as
> the diff for Wfloat-conversion.c is as a new file, not
as a copy of
> Wconversion-real.c. Thanks for reviewing
it. If there is anything
> else that needs changing, please tell me.
> For gcc/c-family/ChangeLog:
> PR c/53001
> Splitting out a -Wfloat-conversion
from -Wconversion for
> conversions that lower floating
point number precision
> or conversion from floating point
numbers to integers
> * c-common.c (unsafe_conversion_p):
Make this function
> return an enumeration with more
This is nicely formatted now, thank you.
> (conversion_warning): Use the new
return type of
> unsafe_conversion_p to separately
warn either about conversions
> that lower floating point number
precision or about the other
> kinds of conversions.
> * c-common.h: Adding
> (unsafe_conversion_p): switching
return type to
> conversion_safety enumeration.
Here, this should be:
* c-common.h (enum conversion_safety):
(unsafe_conversion_p): switching return
OK to commit with the above changes, if you have your
assigned to the FSF.
Thank for working on this. It is appreciated.